Skip to content

Revert "Disallow numeric literals with negative numbers (#55268)" - #56422

Merged
Jake Bailey (jakebailey) merged 2 commits into
microsoft:mainfrom
jakebailey:revert-55268
Nov 15, 2023
Merged

Revert "Disallow numeric literals with negative numbers (#55268)"#56422
Jake Bailey (jakebailey) merged 2 commits into
microsoft:mainfrom
jakebailey:revert-55268

Conversation

@jakebailey

@jakebailey Jake Bailey (jakebailey) commented Nov 15, 2023

Copy link
Copy Markdown
Member

This reverts #55268.

Closes #56301
Updates #56272

For 5.3 it seemed too risky to take this change; there's a lot more inconsistency we've discovered at the last minute and changing it again later seemed bad.

Also #56270 shows that this behavior was being depended on as TS lacks true infinity types.

@jakebailey
Jake Bailey (jakebailey) merged commit 3333e90 into microsoft:main Nov 15, 2023
@jakebailey

Copy link
Copy Markdown
Member Author

TypeScript Bot (@typescript-bot) cherry-pick this to release-5.3

@typescript-bot

TypeScript Bot (typescript-bot) commented Nov 15, 2023

Copy link
Copy Markdown
Contributor

Heya Jake Bailey (@jakebailey), I've started to run the task to cherry-pick this into release-5.3 on this PR at 45371af. You can monitor the build here.

@typescript-bot

Copy link
Copy Markdown
Contributor

Hey Jake Bailey (@jakebailey), I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-5.3 manually.

@jakebailey

Copy link
Copy Markdown
Member Author

sigh

@jakebailey

Copy link
Copy Markdown
Member Author

TypeScript Bot (@typescript-bot) cherry-pick this to release-5.3

@typescript-bot

TypeScript Bot (typescript-bot) commented Nov 16, 2023

Copy link
Copy Markdown
Contributor

Heya Jake Bailey (@jakebailey), I've started to run the task to cherry-pick this into release-5.3 on this PR at 45371af. You can monitor the build here.

@typescript-bot

Copy link
Copy Markdown
Contributor

Hey Jake Bailey (@jakebailey), I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-5.3 manually.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants